search

kubernetes-retired / etcdadm

[EOL] etcdadm is a command-line tool for operating an etcd cluster
Apache License 2.0
765 stars 135 forks source link

etcd-manager - Allow all 3.X upgrades of one minor version #253

Closed rifelpet closed 2 years ago

rifelpet commented 2 years ago

This is a bit more future-proof and lower maintenance. This should cover all 3.X upgrades of up to one minor version.

ref: https://github.com/kubernetes/kops/issues/12662

justinsb commented 2 years ago

Yes, this seems like a good idea. We could also enforce this via tests, but as we're working towards supporting etcd versions running in a separate container/pod, this approach is more sustainable.

Thanks @rifelpet

/approve /lgtm

k8s-ci-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[etcd-manager/OWNERS](https://github.com/kubernetes-sigs/etcdadm/blob/master/etcd-manager/OWNERS)~~ [justinsb,rifelpet] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment