search

kubernetes-retired / etcdadm

[EOL] etcdadm is a command-line tool for operating an etcd cluster
Apache License 2.0
765 stars 135 forks source link

Remove the service arg from InitSystem #263

Closed justinsb closed 2 years ago

justinsb commented 2 years ago

It was only passed a constant value, and arguably the wrong value if the user overrides the UnitFile.

Fixing this moves us closer to reuse of the InitSystem.

k8s-ci-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/etcdadm/blob/master/OWNERS)~~ [justinsb,rifelpet] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment