search

kubernetes-retired / etcdadm

[EOL] etcdadm is a command-line tool for operating an etcd cluster
Apache License 2.0
765 stars 135 forks source link

Add support for listening to IPv6 #270

Closed olemarkus closed 2 years ago

olemarkus commented 2 years ago

If instances are using Resource Based Naming, we are guaranteed to have ipv6 addresses and we use them between etcd-manager instances.

This will also make etcd-manager work in ipv6-native/only subnets.

This PR also makes it possible for etcd-manager to create an etcd cluster listening on ipv6, but the default remains listening on ipv4.

This PR is tested in https://github.com/kubernetes/kops/pull/12855

olemarkus commented 2 years ago

/retest

k8s-ci-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman, olemarkus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[etcd-manager/OWNERS](https://github.com/kubernetes-sigs/etcdadm/blob/master/etcd-manager/OWNERS)~~ [hakman,olemarkus] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
hakman commented 2 years ago

/lgtm