kubernetes-retired / etcdadm

[EOL] etcdadm is a command-line tool for operating an etcd cluster

Apache License 2.0

765 stars 135 forks source link

Add back etcd 3.5.0 #279

Closed olemarkus closed 2 years ago

olemarkus commented 2 years ago

261 removed the 3.5.0 binary, which breaks at least all kops upgrades from 1.22.{0,1,2} to 1.22.3, which already uses 3.5.0. The reason being that etcd-manager will first start etcd using the current version, and only then start etcd with the new version.

/cc @zetaab @hakman

xref: https://github.com/kubernetes/kops/issues/13118

k8s-ci-robot commented 2 years ago

@olemarkus: GitHub didn't allow me to request PR reviews from the following users: zetaab.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/kubernetes-sigs/etcdadm/pull/279): >#261 removed the 3.5.0 binary, which breaks at least all kops upgrades from 1.22.{0,1,2} to 1.22.3, which already uses 3.5.0. The reason being that etcd-manager will first start etcd using the current version, and only then start etcd with the new version. > >/cc @zetaab @hakman Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

olemarkus commented 2 years ago

/retest

olemarkus commented 2 years ago

/retest

olemarkus commented 2 years ago

/retest

olemarkus commented 2 years ago

Not sure why it cannot clean up the files of that node. I cannot reproduce this locally. /retest

olemarkus commented 2 years ago

Ah doh. it is of course not reacting to retest ...

zetaab commented 2 years ago

/lgtm

k8s-ci-robot commented 2 years ago

@zetaab: changing LGTM is restricted to collaborators

In response to [this](https://github.com/kubernetes-sigs/etcdadm/pull/279#issuecomment-1022184128): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

hakman commented 2 years ago

It will not merge until the test passes...

k8s-ci-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olemarkus, rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[etcd-manager/OWNERS](https://github.com/kubernetes-sigs/etcdadm/blob/master/etcd-manager/OWNERS)~~ [olemarkus,rifelpet] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment