search

kubernetes-retired / etcdadm

[EOL] etcdadm is a command-line tool for operating an etcd cluster
Apache License 2.0
765 stars 135 forks source link

Fix ipv6 detection #291

Closed olemarkus closed 2 years ago

olemarkus commented 2 years ago

etcd-manager assumed RBN implied IPv6, but that is not the case. Now it will actually check for an ipv6 address.

Kops-related note: This bug does not affect kops 1.22, which does not use RBN at all. But it will affect 1.23+.

k8s-ci-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman, olemarkus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[etcd-manager/OWNERS](https://github.com/kubernetes-sigs/etcdadm/blob/master/etcd-manager/OWNERS)~~ [hakman,olemarkus] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment