search

kubernetes-retired / etcdadm

[EOL] etcdadm is a command-line tool for operating an etcd cluster
Apache License 2.0
765 stars 135 forks source link

`etcd-manager` default control store path #333

Closed duxing closed 1 year ago

duxing commented 2 years ago

A question for legacy etcd-manager:

Not the most exciting topic but I can't find a better place for this question (etcd-manager has been archived in favor of this project)

I'm stuck on this old version(3.0.20190930) of etcd-manager and noticed the same behavior on the latest version of etcd-manager too:

the control store is reusing the path for backup (reference). is this desired?

the data from the control store are being used for both controller and backupcontroller. for example, control store contains data to see if a cluster is new (reference)

with the current set up, if we specify a S3 bucket for backup, e.g. s3://foobar, the object hierarchy will look like this:

...
s3://foobar/backup/etcd/main/control/
s3://foobar/backup/etcd/main/control/etcd-cluster-created
s3://foobar/backup/etcd/main/control/etcd-cluster-spec
s3://foobar/backup/etcd/main/2022-01-01T00:00:00Z-123456/
...

where to me what would make more sense would be:

...
s3://foobar/etcd/main/control/
s3://foobar/etcd/main/control/etcd-cluster-created
s3://foobar/backup/etcd/main/control/etcd-cluster-spec
s3://foobar/backup/etcd/main/2022-01-01T00:00:00Z-123456/
...

so that backup dir will contain backup data only, preventing accidentally deleting the control files

duxing commented 2 years ago

@justinsb can you take a look when you have a chance?

k8s-triage-robot commented 1 year ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 1 year ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot commented 1 year ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

k8s-ci-robot commented 1 year ago

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to [this](https://github.com/kubernetes-sigs/etcdadm/issues/333#issuecomment-1368303131): >The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. > >This bot triages issues according to the following rules: >- After 90d of inactivity, `lifecycle/stale` is applied >- After 30d of inactivity since `lifecycle/stale` was applied, `lifecycle/rotten` is applied >- After 30d of inactivity since `lifecycle/rotten` was applied, the issue is closed > >You can: >- Reopen this issue with `/reopen` >- Mark this issue as fresh with `/remove-lifecycle rotten` >- Offer to help out with [Issue Triage][1] > >Please send feedback to sig-contributor-experience at [kubernetes/community](https://github.com/kubernetes/community). > >/close not-planned > >[1]: https://www.kubernetes.dev/docs/guide/issue-triage/ Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.