Closed Mia-Cross closed 1 year ago
Hi @Mia-Cross. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Mia-Cross
Once this PR has been reviewed and has the lgtm label, please assign justinsb for approval by writing /assign @justinsb
in a comment. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
This PR was made in order to support master instance groups with more than one instance, which I recently learned we're not really supposed to do so it's not useful. The new one is #345.
Scaleway doesn't allow multi-attach of volumes, that's' why we had to make a few changes in order for the etcd-manager to work with Scaleway.