Closed Mia-Cross closed 1 year ago
Hi @Mia-Cross. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
/ok-to-test
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: hakman, Mia-Cross
The full list of commands accepted by this bot can be found here.
The pull request process is described here
My other PR (#345) references a tag from the
scaleway
package (k8s.io/kops/upup/pkg/fi/cloudup/scaleway
) which was only added recently so in order for it to pass the tests I need to update dependencies first and have etcd-manager use the latest version of kops (v1.26.0-alpha.2)