search

kubernetes-retired / etcdadm

[EOL] etcdadm is a command-line tool for operating an etcd cluster
Apache License 2.0
765 stars 135 forks source link

Use etcd 3.4 client #363

Closed justinsb closed 1 year ago

justinsb commented 1 year ago

3.5 seems to have regressed on https://github.com/kubernetes/kubernetes/issues/72102

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/etcdadm/blob/master/OWNERS)~~ [justinsb] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
justinsb commented 1 year ago

/test cluster-create-phases-test

k8s-ci-robot commented 1 year ago

@justinsb: The specified target(s) for /test were not found. The following commands are available to trigger required jobs:

Use /test all to run all jobs.

In response to [this](https://github.com/kubernetes-sigs/etcdadm/pull/363#issuecomment-1416778988): >/test cluster-create-phases-test Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
hakman commented 1 year ago

/lgtm /hold in case there's something missing

justinsb commented 1 year ago

This is looking good I think ... 3.4 is passing, 3.5 is failing only on the test which shows the regression. Going to merge this one.

/hold cancel