kubernetes-retired / etcdadm

[EOL] etcdadm is a command-line tool for operating an etcd cluster
Apache License 2.0
765 stars 135 forks source link

WIP: [demonstrates regression] Use etcd 3.5 client #364

Closed justinsb closed 1 year ago

justinsb commented 1 year ago

Update to etcd 3.5 client, shows a regression.

Do not merge :-)

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/etcdadm/blob/master/OWNERS)~~ [justinsb] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
k8s-triage-robot commented 1 year ago

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

justinsb commented 1 year ago

We have worked around the regression, I think we can close

/close

k8s-ci-robot commented 1 year ago

@justinsb: Closed this PR.

In response to [this](https://github.com/kubernetes-sigs/etcdadm/pull/364#issuecomment-1567944637): >We have worked around the regression, I think we can close > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.