search

kubernetes-retired / external-storage

[EOL] External storage plugins, provisioners, and helper libraries
Apache License 2.0
2.7k stars 1.6k forks source link

fix broken links #1260

Closed ydcool closed 4 years ago

ydcool commented 4 years ago

Signed-off-by: Dominic Yin yindongchao@inspur.com

Fixed several broken links :

  1. https://github.com/openebs/mayaserver moved to >> https://github.com/openebs/maya/tree/master/cmd/maya-apiserver, see https://github.com/openebs/maya/pull/95

  2. https://raw.githubusercontent.com/kubernetes/kubernetes/master/examples/persistent-volume-provisioning/aws-ebs.yaml movde to https://github.com/kubernetes/examples/blob/master/staging/persistent-volume-provisioning/aws-ebs.yaml, see https://github.com/kubernetes/kubernetes/issues/23671

  3. https://github.com/jinxu97 should be https://github.com/jingxu97, as a typo

k8s-ci-robot commented 4 years ago

Welcome @ydcool!

It looks like this is your first PR to kubernetes-incubator/external-storage 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-incubator/external-storage has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

ydcool commented 4 years ago

/assign @childsb

muratkars commented 4 years ago

/lgtm

k8s-ci-robot commented 4 years ago

@muratkars: changing LGTM is restricted to collaborators

In response to [this](https://github.com/kubernetes-incubator/external-storage/pull/1260#issuecomment-558284372): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
wongma7 commented 4 years ago

/lgtm /approve

TY

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-incubator/external-storage/blob/master/OWNERS)~~ [wongma7] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment