kubernetes-retired / external-storage

[EOL] External storage plugins, provisioners, and helper libraries
Apache License 2.0
2.7k stars 1.6k forks source link

Fixed AWS EFS deployment example #1264

Closed eschizoid closed 4 years ago

eschizoid commented 4 years ago

The purpose of this PR is just to update a deprecated K8s API that no longer works when using AWS EFS.

k8s-ci-robot commented 4 years ago

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
k8s-ci-robot commented 4 years ago

Welcome @eschizoid!

It looks like this is your first PR to kubernetes-incubator/external-storage 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-incubator/external-storage has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

eschizoid commented 4 years ago

/assign @wongma7

eschizoid commented 4 years ago

I've already signed the CLA agreement

humblec commented 4 years ago

@eschizoid dont we have CSI drivers avaialable from AWS for EFS ? if yes, can you use that provisioner ? obviously we can review this PR, but bringing another thought here.

eschizoid commented 4 years ago

@humblec IMO the CSI driver template approach should be for a different PR, this is just updating a deprecated API :)

eschizoid commented 4 years ago

can we merge down this bad boy?

wongma7 commented 4 years ago

/lgtm /approve thanks. sorry for the wait, am reviewing PRs now!

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[aws/efs/OWNERS](https://github.com/kubernetes-incubator/external-storage/blob/master/aws/efs/OWNERS)~~ [wongma7] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment