search

kubernetes-retired / external-storage

[EOL] External storage plugins, provisioners, and helper libraries
Apache License 2.0
2.7k stars 1.6k forks source link

nfs-provisioner v2.3.0: deployment.yaml does not contain all needed port for v2.3.0 quay image #1277

Closed radtriste closed 4 years ago

radtriste commented 4 years ago

related to https://github.com/kubernetes-incubator/external-storage/issues/1262

Image has been updated on Quay to v2.3.0 but deployment.yaml on nfs-provisioner-v2.3.0 tag does not include the latest port(s).

radtriste commented 4 years ago

service and deployment are missing some TCP/UDP ports. using current master is ok, but the tag should contain the correct deployment.yaml

appunni-m commented 4 years ago

Is this still pending ?

radtriste commented 4 years ago

this is pending. The fix mentioned in this issue is only in our internal repository and not on this one. nothing has changed on your side.

radtriste commented 4 years ago

do we have an update for this ? Planning a 2.3.1 or something ?

For now we use the 2.2.2 as workaround ...

appunni-m commented 4 years ago

I am using 2.3.0 it is working. Using the stable/nfs-server-provisioner

radtriste commented 4 years ago

What is stable/nfs-server-provisioner ?

When you try to deploy in kubernetes the deployment.yaml, the pod is starting well. But when requesting a new volume storage, you get an error into the nfs-provisioner that some ports are unavailable.

This is because the quay image is needing much more opened ports on deployment/service than before: https://github.com/kubernetes-incubator/external-storage/compare/nfs-provisioner-v2.3.0...master (look for nfs/deploy/kubernetes/deployment.yaml). Those latest ports from master need also to be on deployment.yaml from nfs-provisioner-v2.3.0 tag ... Else it does not work.

appunni-m commented 4 years ago

It's a helm chart for setting up a nfs server provisiner for dynamic PV provisioning with PVC . I think they have updated the ports properly in their template.

radtriste commented 4 years ago

Could we correct the deployment.yaml as well ? We are not using helm on our side

duanwei33 commented 4 years ago

@radtriste, agree with you, seems the port part in deployment.yaml with nfs-provisioner-v2.3.0 tag should be updated as master.

wongma7 commented 4 years ago

I don't want to retroactively move the git tag but that is an option. Alternatively, I plan to make a patch to remove the port checking altogether and release 2.3.1 since technically it was a breaking change and it should not have gone out in a release

radtriste commented 4 years ago

Good for me for a 2.3.1

radtriste commented 4 years ago

@wongma7 any planned date on that 2.3.1 tag ?

misko566 commented 4 years ago

I have same problem but. Combination of image "quay.io/kubernetes_incubator/nfs-provisioner tag: v2.2.2" in Values file and "stable/nfs-server-provisioner" as chart worked for me.

Combination of v2.2.2 and downloaded stable chart from "github/helm/charts/stable" also didn't work.

capusta commented 4 years ago

probably same: https://github.com/kubernetes-incubator/external-storage/issues/1282

fejta-bot commented 4 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

nikhita commented 4 years ago

Thanks for reporting the issue!

This repo is no longer being maintained and we are in the process of archiving this repo. Please see https://github.com/kubernetes/org/issues/1563 for more details.

If your issue relates to nfs provisioners, please create a new issue in https://github.com/kubernetes-sigs/nfs-ganesha-server-and-external-provisioner or https://github.com/kubernetes-sigs/nfs-subdir-external-provisioner.

Going to close this issue in order to archive this repo. Apologies for the churn and thanks for your patience! :pray: