Closed duritong closed 4 years ago
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.
It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Welcome @duritong!
It looks like this is your first PR to kubernetes-incubator/external-storage 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes-incubator/external-storage has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign jsafrane
You can assign the PR to them by writing /assign @jsafrane
in a comment when ready.
The full list of commands accepted by this bot can be found here.
Hi @duritong, We are in the middle of migrating the NFS client code into a new home under https://github.com/kubernetes-sigs/nfs-subdir-external-provisioner. The migration PR is up for review at the moment. https://github.com/kubernetes-sigs/nfs-subdir-external-provisioner/pull/2
Pulled in the changes from this commit into the migration PR here. https://github.com/kubernetes-sigs/nfs-subdir-external-provisioner/pull/2/commits/92508da2ff6f629c0467239762b7c8ccce099dc3
Could you please help with reviewing it?
As @kmova mentioned, we are in the process of archiving this repo and continuing work in https://github.com/kubernetes-sigs/nfs-subdir-external-provisioner. Looks like your changes got pulled into the migration PR https://github.com/kubernetes-sigs/nfs-subdir-external-provisioner/pull/2. If you could help in reviewing the PR, that'd be great! :)
Going to close this PR in order to be able to archive this repo.
From OpenShift 4.4 on the built-in SCCs will be managed and thus you cannot any longer mutate them by adding user. The proper way is either to copy an existing SCC or use RBAC to access them.
This updates the documentation for the RBAC approach.