kubernetes-retired / external-storage

[EOL] External storage plugins, provisioners, and helper libraries
Apache License 2.0
2.69k stars 1.6k forks source link

Add support for allSquash, anonUid and anonGid #1320

Closed sopak closed 4 years ago

k8s-ci-robot commented 4 years ago

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
k8s-ci-robot commented 4 years ago

@sopak: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to [this](https://github.com/kubernetes-incubator/external-storage/pull/1320#issuecomment-626863548): >/test Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
sopak commented 4 years ago

/assign @jsafrane @wongma7 thanks

wongma7 commented 4 years ago

This looks good to me aside from a documentation nitpick. However, the code for this app was recently moved to https://github.com/kubernetes-sigs/nfs-ganesha-server-and-external-provisioner, so if you want this to be built and released it will be better to recreate the PR there and I will drop an /lgtm there. (This repository is still missing a notice about the migration, my apologies).

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign jsafrane You can assign the PR to them by writing /assign @jsafrane in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[nfs/OWNERS](https://github.com/kubernetes-incubator/external-storage/blob/master/nfs/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
nikhita commented 4 years ago

@sopak Thanks for your PR!

As @wongma7 mentioned, we are in the process of archiving this repo and are no longer accepting new PRs. Please see https://github.com/kubernetes/org/issues/1563 for more details.

We have a tracking issue open to pull in changes from this PR though - https://github.com/kubernetes-sigs/nfs-ganesha-server-and-external-provisioner/issues/5.

Going to close this PR in order to archive this repo. Thanks again!