Closed sopak closed 4 years ago
@sopak: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test
message.
/assign @jsafrane @wongma7 thanks
This looks good to me aside from a documentation nitpick. However, the code for this app was recently moved to https://github.com/kubernetes-sigs/nfs-ganesha-server-and-external-provisioner, so if you want this to be built and released it will be better to recreate the PR there and I will drop an /lgtm there. (This repository is still missing a notice about the migration, my apologies).
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign jsafrane
You can assign the PR to them by writing /assign @jsafrane
in a comment when ready.
The full list of commands accepted by this bot can be found here.
@sopak Thanks for your PR!
As @wongma7 mentioned, we are in the process of archiving this repo and are no longer accepting new PRs. Please see https://github.com/kubernetes/org/issues/1563 for more details.
We have a tracking issue open to pull in changes from this PR though - https://github.com/kubernetes-sigs/nfs-ganesha-server-and-external-provisioner/issues/5.
Going to close this PR in order to archive this repo. Thanks again!
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.
It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.