search

kubernetes-retired / external-storage

[EOL] External storage plugins, provisioners, and helper libraries
Apache License 2.0
2.69k stars 1.6k forks source link

Migrate to policy/v1beta1 API #1322

Closed 0xMH closed 4 years ago

0xMH commented 4 years ago

Migrate to use the policy/v1beta1 API, available since v1.10. Because PodSecurityPolicy in the extensions/v1beta1 is a Deprecated API Removed In 1.16.

k8s-ci-robot commented 4 years ago

Welcome @0xMH!

It looks like this is your first PR to kubernetes-incubator/external-storage 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-incubator/external-storage has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign jsafrane You can assign the PR to them by writing /assign @jsafrane in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[nfs/OWNERS](https://github.com/kubernetes-incubator/external-storage/blob/master/nfs/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
0xMH commented 4 years ago

/assign @jsafrane

kmova commented 4 years ago

Thank you @0xMH for this fix. The NFS client code is being migrated to https://github.com/kubernetes-sigs/nfs-subdir-external-provisioner. This change has been taken up as part of this migration PR. https://github.com/kubernetes-sigs/nfs-subdir-external-provisioner/pull/2/commits/234543e14d416979d3397e40940cae99bc241365

nikhita commented 4 years ago

@0xMH Thanks for your PR! As @kmova mentioned, we are in the process of archiving this repo and are no longer accepting new PRs here. Please see https://github.com/kubernetes/org/issues/1563 for more details.

Looks like your commit got bundled up into the migration PR though. :)