kubernetes-retired / external-storage

[EOL] External storage plugins, provisioners, and helper libraries
Apache License 2.0
2.69k stars 1.6k forks source link

fix bug: gluster file params does not take effect #1333

Closed lowang-bh closed 4 years ago

lowang-bh commented 4 years ago

It always use the default volumetype due to the parsed config is not used

k8s-ci-robot commented 4 years ago

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
k8s-ci-robot commented 4 years ago

Welcome @lowang-bh!

It looks like this is your first PR to kubernetes-incubator/external-storage 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-incubator/external-storage has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

lowang-bh commented 4 years ago

/assign @humblec

lowang-bh commented 4 years ago

I signed it

lowang-bh commented 4 years ago

I signed it

lowang-bh commented 4 years ago

/assign @jsafrane

humblec commented 4 years ago

@lowang-bh thanks for the PR. One thing to note here is, this repo is under deprecation, so may be getting this PR in may not add much value. The PR looks good to me though

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign jsafrane You can assign the PR to them by writing /assign @jsafrane in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[ceph/cephfs/OWNERS](https://github.com/kubernetes-incubator/external-storage/blob/master/ceph/cephfs/OWNERS)** - **[gluster/file/OWNERS](https://github.com/kubernetes-incubator/external-storage/blob/master/gluster/file/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
lowang-bh commented 4 years ago

/assign rootfs

lowang-bh commented 4 years ago

@lowang-bh thanks for the PR. One thing to note here is, this repo is under deprecation, so may be getting this PR in may not add much value. The PR looks good to me though

Yes, it is to be deprecate. But there is also someone using this external-storage, so I think it is useful to fix the issue so that others can use it directly. So can you approve it?

nikhita commented 4 years ago

@lowang-bh Thanks for your PR!

We are in the process of archiving this repo and are no longer accepting new PRs. Please see https://github.com/kubernetes/org/issues/1563 for more details.

But there is also someone using this external-storage, so I think it is useful to fix the issue so that others can use it directly.

If you need specific code to be still maintained, please reach out to sig-storage on their mailing list. We've done that for certain code paths like https://github.com/kubernetes/org/issues/1743 and https://github.com/kubernetes/org/issues/1744