Closed lowang-bh closed 4 years ago
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.
It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Welcome @lowang-bh!
It looks like this is your first PR to kubernetes-incubator/external-storage 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes-incubator/external-storage has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
/assign @humblec
I signed it
I signed it
/assign @jsafrane
@lowang-bh thanks for the PR. One thing to note here is, this repo is under deprecation, so may be getting this PR in may not add much value. The PR looks good to me though
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign jsafrane
You can assign the PR to them by writing /assign @jsafrane
in a comment when ready.
The full list of commands accepted by this bot can be found here.
/assign rootfs
@lowang-bh thanks for the PR. One thing to note here is, this repo is under deprecation, so may be getting this PR in may not add much value. The PR looks good to me though
Yes, it is to be deprecate. But there is also someone using this external-storage, so I think it is useful to fix the issue so that others can use it directly. So can you approve it?
@lowang-bh Thanks for your PR!
We are in the process of archiving this repo and are no longer accepting new PRs. Please see https://github.com/kubernetes/org/issues/1563 for more details.
But there is also someone using this external-storage, so I think it is useful to fix the issue so that others can use it directly.
If you need specific code to be still maintained, please reach out to sig-storage on their mailing list. We've done that for certain code paths like https://github.com/kubernetes/org/issues/1743 and https://github.com/kubernetes/org/issues/1744
It always use the default volumetype due to the parsed config is not used