kubernetes-retired / external-storage

[EOL] External storage plugins, provisioners, and helper libraries
Apache License 2.0
2.69k stars 1.6k forks source link

Update path creation and implemented possibility save data after removing PV #1340

Closed BledaiOld closed 4 years ago

BledaiOld commented 4 years ago

Hello,

This PR resolved issue #1339.

In the scope of this PR was added the ability to use metadate (name, namespace, labels, annotations) PVC field for dynamical creation the pvPath and possibility saving data on nfs-storage after deletion PV.

Example:

StorageClass:

apiVersion: storage.k8s.io/v1
kind: StorageClass
metadata:
  namespace: kube-system
  name: managed-nfs-storage-test-2
provisioner: fuseim.pri/ifs 
parameters:
  archiveOnDelete: "false"
  pathPattern: "{pvc.namespace}/{pvc.name}"
  onDelete: "retain"

PersistentVolumeClaim:

apiVersion: storage.k8s.io/v1
kind: StorageClass
metadata:
  namespace: kube-system
  name: managed-nfs-storage-test-2
provisioner: fuseim.pri/ifs 
parameters:
  onDelete: "retain"
  pathPattern: "{pvc.namespace}/{pvc.name}"
k8s-ci-robot commented 4 years ago

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
k8s-ci-robot commented 4 years ago

Welcome @Bledai!

It looks like this is your first PR to kubernetes-incubator/external-storage 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-incubator/external-storage has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign wongma7 You can assign the PR to them by writing /assign @wongma7 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-incubator/external-storage/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
BledaiOld commented 4 years ago

/assign @wongma7 @jsafrane

BledaiOld commented 4 years ago

/assign @jsafrane

kmova commented 4 years ago

@Bledai - thank you for this PR.

We are in the middle of migrating the NFS client code into a new home under https://github.com/kubernetes-sigs/nfs-subdir-external-provisioner. The migration PR is up for review at the moment. https://github.com/kubernetes-sigs/nfs-subdir-external-provisioner/pull/2

Can I request you to raise the PR on the new repo, once the above migration PR is closed?

Thank you for working on this fix.

BledaiOld commented 4 years ago

@Bledai - thank you for this PR.

We are in the middle of migrating the NFS client code into a new home under https://github.com/kubernetes-sigs/nfs-subdir-external-provisioner. The migration PR is up for review at the moment. kubernetes-sigs/nfs-subdir-external-provisioner#2

Can I request you to raise the PR on the new repo, once the above migration PR is closed?

Thank you for working on this fix.

@kmova Thanks for your response. Got it, I'm going to open PR for a new home after PR migrations will be merged.

nikhita commented 4 years ago

As @kmova mentioned, we are in the process of archiving this repo and continuing work in https://github.com/kubernetes-sigs/nfs-subdir-external-provisioner. Please reopen a PR in the new repo once https://github.com/kubernetes-sigs/nfs-subdir-external-provisioner/pull/2 has merged. Thanks for your patience! :)

Going to close this PR in order to be able to archive this repo.