search

kubernetes-retired / external-storage

[EOL] External storage plugins, provisioners, and helper libraries
Apache License 2.0
2.69k stars 1.6k forks source link

Add environment variable to allow skipping leader election #1352

Closed linki closed 4 years ago

linki commented 4 years ago

This PR addresses https://github.com/kubernetes-incubator/external-storage/issues/1184 by allowing to turn off leader election as mentioned in https://github.com/kubernetes-incubator/external-storage/issues/1184#issuecomment-624691714.

Leader election can be turned off by setting the env var SKIP_LEADER_ELECTION=1.

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign jsafrane You can assign the PR to them by writing /assign @jsafrane in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-incubator/external-storage/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
mrbobbytables commented 4 years ago

@linki This repo is in the process of archival with several components being migrated over to k-sigs:

https://github.com/kubernetes-sigs/gluster-file-external-provisioner https://github.com/kubernetes-sigs/gluster-block-external-provisioner https://github.com/kubernetes-sigs/nfs-ganesha-server-and-external-provisioner https://github.com/kubernetes-sigs/nfs-subdir-external-provisioner

mrbobbytables commented 4 years ago

Going to go ahead and close this out. Please consider updating it in their migrated locations /close

k8s-ci-robot commented 4 years ago

@mrbobbytables: Closed this PR.

In response to [this](https://github.com/kubernetes-incubator/external-storage/pull/1352#issuecomment-670482832): >Going to go ahead and close this out. Please consider updating it in their migrated locations >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.