kubernetes-retired / go-open-service-broker-client

A golang client for service brokers implementing the Open Service Broker API
Apache License 2.0
62 stars 51 forks source link

Mismatch between this library and OSB schema #101

Closed pmorie closed 6 years ago

pmorie commented 6 years ago

As @luksa pointed out in #96, parts of this library's types don't match the OSB schema.

luksa commented 6 years ago

Preliminary work here: https://github.com/luksa/go-open-service-broker-client/commit/9d92a62a118116cd946f6be5881ee12002fc8a41

Note that the names in the OpenAPI spec are slightly different (and more accurate IMHO). For example, there's ServiceInstanceSchemaObject. I'd remove the "Object" suffix, but I like including "Schema" at the end. ServiceInstanceSchema is much clearer than ServiceInstance.

Also note that this should really be called ServiceInstanceSchemas (plural), to make it consistent with Schemas and the fact that it actually contains multiple schemas (create and update, with each of them again containing multiple schemas: parameters and response). The naming should also be fixed in the spec itself. I've filed an issue here.

pmorie commented 6 years ago

@luksa I think now that https://github.com/openservicebrokerapi/servicebroker/pull/459 is closed, we can proceed with this, correct?