search

kubernetes-retired / go-open-service-broker-client

A golang client for service brokers implementing the Open Service Broker API
Apache License 2.0
62 stars 51 forks source link

enforce required fields on fake ProvisionRequest #122

Closed MHBauer closed 5 years ago

MHBauer commented 6 years ago

@pmorie @duglin who has merge perms on this repo?

for #121 to help enforce upstream usage in service-catalog.

Not required, but can be done piecemeal. Maybe good for new contributors?

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.04%) to 92.586% when pulling 4163fc897a62ae03ab77416bb3f619df45d5e2fd on MHBauer:required-fields-provision-request-fake into 00e5660c0d7f5f3475a988dfc54874e7d4eeacde on pmorie:master.

MHBauer commented 6 years ago

I don't understand what changed or what changes it wants

jboyd01 commented 5 years ago

Hey @MHBauer I was just reviewing this. I would prefer to see us call out the specific field that is missing (yes there could be multiple, I don't care if we only said the first one identified as missing was reported even if there are multiple) - - otherwise it's a guessing game/back to RTFM. WDYT? Any interesting in updating this?

jboyd01 commented 5 years ago

reviewed with Jonathan Berkhahn, merging, we can iterate if desired.