kubernetes-retired / go-open-service-broker-client

A golang client for service brokers implementing the Open Service Broker API
Apache License 2.0
61 stars 51 forks source link

Add support for OSBAPI 2.15 #161

Closed edwardecook closed 2 years ago

edwardecook commented 4 years ago

It would be great to get this client up to date with the current version of the OSBAPI spec (which is now on 2.16). This is an interim step to add support for 2.15.

Below is the list of 2.15 release notes, the plan is to categorise them by whether the work has already been done, work is needed or if it is not relevant to this library.

Feature Current Status
Added a delay to polling response for Service Instance and Service Binding last operations. WORK REQUIRED
Added a Service Offering specific async polling timeout. WORK REQUIRED
Allow a Service Instance context to be updated and add org name, space name, and instance names. WORK REQUIRED
Added list of endpoints to create Service Binding response body. WORK REQUIRED
Add plan_updateable field to the Service Plan object. WORK REQUIRED
Added maintenance info support to Service Plans. WORK REQUIRED
Added request identity header. WORK REQUIRED
Allow brokers to not return parameters when returning a Service Instance or Service Binding. N/A
Restrict Operation strings to 10,000 chartacters in the response body for provisioning or deprovisioning a Service Instance, and binding or unbinding a Service Binding. N/A
Remove character restrictions on names of Service Offerings, and Service Plans. N/A
Allow empty descriptions in the response body for getting the last operations of Service Instances, and Service Bindings. N/A
Added mechanism for orphan mitigation. N/A
Allow brokers to return 200 for no-op update Service Instance requests. N/A
Clarify what happens when deleting during a provision/bind request. N/A
Clarify broker behavior expected when deprovisioning while a provision request is in progress and unbinding while an unbind request is in progress. N/A
Clarify broker behavior when a provision request is received during a provision request for the same instance or when a binding request is received during a binding request for the same binding. N/A

For implementation it would probably make sense to follow the same pattern as for 2.14, #144, i.e. PR in features as Alpha features and once it is all implemented a final PR to move them out of Alpha and add Version2_15 to the client.

Hopefully that sounds reasonable?

jhvhs commented 4 years ago

Status update:

fejta-bot commented 3 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

jhvhs commented 3 years ago

/remove-lifecycle stale

mrbobbytables commented 2 years ago

This project is being archived, closing open issues and PRs. Please see this PR for more information: https://github.com/kubernetes/community/pull/6632