kubernetes-retired / go-open-service-broker-client

A golang client for service brokers implementing the Open Service Broker API
Apache License 2.0
62 stars 51 forks source link

Fix: Route from BindRequest not passed on #167

Closed fabstu closed 4 years ago

fabstu commented 4 years ago

If there is a Route in the Bind Request then put it into the map instead of AppGUID again.

k8s-ci-robot commented 4 years ago

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
k8s-ci-robot commented 4 years ago

Welcome @fabstu!

It looks like this is your first PR to kubernetes-sigs/go-open-service-broker-client 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/go-open-service-broker-client has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

fabstu commented 4 years ago

I signed it

jberkhahn commented 4 years ago

Pretty sure this resource is part of route services, which Service Catalog doesn't currently support, or ever plan to. That doesn't necessarily that we should be sticking it in the app guide, but something to think about.

jhvhs commented 4 years ago

Good catch, thanks @fabstu /lgtm

jhvhs commented 4 years ago

Pretty sure this resource is part of route services, which Service Catalog doesn't currently support, or ever plan to. That doesn't necessarily that we should be sticking it in the app guide, but something to think about.

Sorry @jberkhahn, I missed your message. I can't see why the library shouldn't follow the spec, given that it supports all the rest of the fields required for the flow. Is it interfering in any way with the Service Catalog, or am I missing something?

/assign @jberkhahn

jberkhahn commented 4 years ago

Ok, but let it be on your head. /approve

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabstu, jberkhahn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/go-open-service-broker-client/blob/master/OWNERS)~~ [jberkhahn] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment