search

kubernetes-retired / go-open-service-broker-client

A golang client for service brokers implementing the Open Service Broker API
Apache License 2.0
61 stars 51 forks source link

Library should support previous_values in UpdateInstanceRequest #94

Closed girikuncoro closed 6 years ago

girikuncoro commented 6 years ago

I'm currently using this library to build a component that's talking to on demand service broker. As written in the comment, the library is missing previous_values field in UpdateInstanceRequest here

This is important missing piece for me because the broker I talk to requires previous_values for updating service instance which is according to the spec. Specifically the broker will look for previous_values here which is currently empty since the library is not passing it on.

If you are ok, I can make a PR for this.

cc @frodenas

pmorie commented 6 years ago

I’m happy to accept a PR for this.

On Thu, Feb 1, 2018 at 10:36 PM Giri Kuncoro notifications@github.com wrote:

I'm currently using this library to build a component that's talking to on demand service broker https://github.com/pivotal-cf/on-demand-service-broker. As written in the comment, the library is missing previous_values field in UpdateInstanceRequest here https://github.com/pmorie/go-open-service-broker-client/blob/master/v2/types.go#L228

This is important missing piece for me because the broker I talk to requires previous_values for updating service instance which is according to the spec https://github.com/openservicebrokerapi/servicebroker/blob/v2.13/spec.md#updating-a-service-instance. Specifically the broker will look for previous_values here https://github.com/pivotal-cf/on-demand-service-broker/blob/master/broker/update.go#L52 which is currently empty since the library is not passing it on.

If you are ok, I can make a PR for this.

cc @frodenas https://github.com/frodenas

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/pmorie/go-open-service-broker-client/issues/94, or mute the thread https://github.com/notifications/unsubscribe-auth/AAWXmP8WnOtWs9XgQHFUWgXok4668hSjks5tQjx0gaJpZM4R2ZWK .

pmorie commented 6 years ago

Closed by #95