kubernetes-retired / heapster

[EOL] Compute Resource Usage Analysis and Monitoring of Container Clusters

Apache License 2.0

2.63k stars 1.25k forks source link

ES Sink: Support clusterName attribute #1383

Closed matthughes closed 7 years ago

matthughes commented 8 years ago

I have multiple K8S clusters all logging to the same Elasticsearch cluster. It would be great if we could add a root-level field cluster-name to the sink.

piosz commented 7 years ago

cc @AlmogBaku @huangyuqi @jamiehannaford

AlmogBaku commented 7 years ago

1380

piosz commented 7 years ago

@AlmogBaku @andyxning is #1380 fixing this?

andyxning commented 7 years ago

I think so. I will try to make it tomorrow. The requirement is the same

andyxning commented 7 years ago

@matthughes Do you mean that you want this behavior for both events(eventer) and metric(heapster)?

matthughes commented 7 years ago

Both I would think. It would be a configuration flag of the ES sink.

andyxning commented 7 years ago

This has been implemented in #1380. Please take a look and review it. :)

======= Ning Xie

2016-12-02 21:49 GMT+08:00 Matt Hughes notifications@github.com:

Both I would think. It would be a configuration flag of the ES sink.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/kubernetes/heapster/issues/1383#issuecomment-264457602, or mute the thread https://github.com/notifications/unsubscribe-auth/ACSxaA8VYALSvF9o1kOCmGmqK6Im-zsPks5rECHQgaJpZM4Ky1IV .