kubernetes-retired / heapster

[EOL] Compute Resource Usage Analysis and Monitoring of Container Clusters
Apache License 2.0
2.63k stars 1.25k forks source link

change the func name of creating influxdb sink #2082

Closed ringtail closed 6 years ago

ringtail commented 6 years ago

In golang. new is a built-in function although you can define your own new function. But when you use a ide with code quality check,It will emit some warnings. lalpby0v5ekmfm_my80cxa_604_203 png_620x10000q90g lalpby0v5ekmfn7mkc0bxw_455_145 png_620x10000q90g Because the built-in new means it returns a pointer to type T a value of type *T, it allocates and zeroes the memory.

What this PR does change the constructor name of influxdb sink.

googlebot commented 6 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
andyxning commented 6 years ago

/ok-to-test

andyxning commented 6 years ago

/lgtm /approve

k8s-ci-robot commented 6 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyxning, ringtail

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[metrics/sinks/influxdb/OWNERS](https://github.com/kubernetes/heapster/blob/master/metrics/sinks/influxdb/OWNERS)~~ [andyxning] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment