search

kubernetes-retired / heapster

[EOL] Compute Resource Usage Analysis and Monitoring of Container Clusters
Apache License 2.0
2.63k stars 1.25k forks source link

change new to newSink #2088

Closed ringtail closed 6 years ago

ringtail commented 6 years ago

same issue about influxdb sink constructor in heapster eventer. link to previous pr：https://github.com/kubernetes/heapster/pull/2082

andyxning commented 6 years ago

/ok-to-test

andyxning commented 6 years ago

@ringtail run make sanitize to check the error.

ringtail commented 6 years ago

@andyxning Thank you. It really helps.

ringtail commented 6 years ago

/retest

andyxning commented 6 years ago

/lgtm /approve

k8s-ci-robot commented 6 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyxning, ringtail

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[events/sinks/influxdb/OWNERS](https://github.com/kubernetes/heapster/blob/master/events/sinks/influxdb/OWNERS)~~ [andyxning] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment