Closed xiezongzhe closed 5 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here (e.g. I signed it!
) and we'll verify it.
Hi @xiezongzhe. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: xiezongzhe To fully approve this pull request, please assign additional approvers. We suggest the following additional approver: andyxning
If they are not already assigned, you can assign the PR to them by writing /assign @andyxning
in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/assign @andyxning
/ok-to-test
@xiezongzhe: The following test failed, say /retest
to rerun them all:
Test name | Commit | Details | Rerun command |
---|---|---|---|
pull-heapster-unit | ffc6ba7f1459e507954d905375b148b36d0eb76c | link | /test pull-heapster-unit |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
@xiezongzhe You need to run make sanitize
locally to find the way to correct the ci error.
promethus->prometheus