search

kubernetes-retired / kpng

[EOL] Reworking kube-proxy's architecture
Apache License 2.0
246 stars 90 forks source link

Add SHA to image tag #512

Closed clearnicki closed 1 year ago

clearnicki commented 1 year ago

This PR adds sha to image tag in E2E_K8S_version

Fixes # 510

linux-foundation-easycla[bot] commented 1 year ago

CLA Signed

The committers listed above are authorized under a signed CLA.

k8s-ci-robot commented 1 year ago

Welcome @clearnicki!

It looks like this is your first PR to kubernetes-sigs/kpng 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kpng has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

seanmalloy commented 1 year ago

/cc /ok-to-test

aroradaman commented 1 year ago

@clearnicki, thank you for working on this, can you create a map of kind Kubernetes versions and corresponding sha digests? The SHA digest should be picked up automatically depending on the provided E2E_K8S_VERSION.

you can refer kind release sections for a list of versions: https://github.com/kubernetes-sigs/kind/releases

clearnicki commented 1 year ago

@daman1807 thanks for the advice. Since this is a bash script - I did a case statement instead of map. Let me know if you would like any more changes or want something else.

aroradaman commented 1 year ago

/lgtm /approve

thanks!

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clearnicki, daman1807

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[hack/OWNERS](https://github.com/kubernetes-sigs/kpng/blob/master/hack/OWNERS)~~ [daman1807] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment