search

kubernetes-retired / kpng

[EOL] Reworking kube-proxy's architecture
Apache License 2.0
246 stars 90 forks source link

ipv4-ipvs: enable passing tests #513

Closed abhaikollara closed 1 year ago

abhaikollara commented 1 year ago

What kind of PR is this?

Test improvement

Why this PR is needed / What this PR do?

Re-enable passing tests for ipv4-ipvs backend. A few tests were unnecessarily skipped, these can now be re-enabled

Which issue(s) this PR fixes?

Relates to #445

mcluseau commented 1 year ago

/lgtm /approve

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhaikollara, mcluseau

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[hack/OWNERS](https://github.com/kubernetes-sigs/kpng/blob/master/hack/OWNERS)~~ [mcluseau] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
aroradaman commented 1 year ago

@mcluseau @jayunit100 These are probably flakes. When I run e2e on a decent Linux box(4 core 16GB) ipvs backend passes all the tests.

Is it possible for any kube-sigs repository to use prow pre-submit jobs? If yes, I can work on that integration 🙂

mcluseau commented 1 year ago

@daman1807 yes many of us have seen less flakiness in local testing. If prow provides that, you can surely go ahead, and it will also help with the visibility of our current state.