search

kubernetes-retired / kpng

[EOL] Reworking kube-proxy's architecture
Apache License 2.0
246 stars 90 forks source link

Populate port mapping name to make endpoint port mapping work. #520

Closed mneverov closed 9 months ago

mneverov commented 1 year ago

What kind of PR is this?

Bug fix: previously, port name was not populated that prevented endpoint port mapping to work correctly.

Why this PR is needed / What this PR do?

This PR fix the issue above.

Which issue(s) this PR fixes?

Fixes # Fixes tests: should be updated after adding or deleting ports and should serve multiport endpoints from pods [Conformance] in e2e-ipv4-iptables mode.

Additional information about this PR

k8s-ci-robot commented 1 year ago

Welcome @mneverov!

It looks like this is your first PR to kubernetes-sigs/kpng 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kpng has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

mneverov commented 1 year ago

question: should I remove should be updated after adding or deleting ports and should serve multiport endpoints from pods [Conformance] tests from ginkgo skip lists for ipv4 and ipv6?

jayunit100 commented 1 year ago

/lgtm /approve

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jayunit100, mneverov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[backends/OWNERS](https://github.com/kubernetes-sigs/kpng/blob/master/backends/OWNERS)~~ [jayunit100] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
k8s-ci-robot commented 1 year ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
k8s-triage-robot commented 9 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-ci-robot commented 9 months ago

New changes are detected. LGTM label has been removed.

mneverov commented 9 months ago

This change has already landed within #532. Closing.