search

kubernetes-retired / kube-aws

[EOL] A command-line tool to declaratively manage Kubernetes clusters on AWS
Apache License 2.0
1.12k stars 295 forks source link

Self hosted canal network doesn't work with kube2iam/kiam #1316

Closed cknowles closed 6 years ago

cknowles commented 6 years ago

Currently when self hosted network is enabled with canal, we configure kube2iam/kiam with network interface of cni0 (since the UseCalico flag is ignored):

https://github.com/kubernetes-incubator/kube-aws/blob/master/core/controlplane/config/templates/cloud-config-controller#L4962-L4966 https://github.com/kubernetes-incubator/kube-aws/blob/master/core/controlplane/config/templates/cloud-config-controller#L5356-L5360

However, this doesn't appear to work. It needs to be cali+ for canal.

Probably we need it before https://github.com/kubernetes-incubator/kube-aws/pull/1309?

davidmccormick commented 6 years ago

Hi, we've not seen any issues with self-hosted canal + kiam in our hcom clusters. Aha, good spot - we do still have the UseCalico option in our clusters which is set to True. I think we are going to need to extend these if conditions with either method and then remove 'UseCalico' when we make Self/Hosting the default setting.

I'll PR the required expansion...