search

kubernetes-retired / kube-aws

[EOL] A command-line tool to declaratively manage Kubernetes clusters on AWS
Apache License 2.0
1.12k stars 295 forks source link

[v0.16.1] Fix rendering for openICMP #1867

Closed dominicgunn closed 4 years ago

dominicgunn commented 4 years ago

Changes

Rendering for the new openICMP feature was broken when more than one addressed was assigned to sshAccessAllowedSourceCIDRs, this fixes it.

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign dominicgunn You can assign the PR to them by writing /assign @dominicgunn in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-incubator/kube-aws/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov-commenter commented 4 years ago

Codecov Report

Merging #1867 into v0.16.x will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           v0.16.x    #1867   +/-   ##
========================================
  Coverage    24.41%   24.41%           
========================================
  Files           98       98           
  Lines         5116     5116           
========================================
  Hits          1249     1249           
  Misses        3727     3727           
  Partials       140      140

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a43cd06...ba4664d. Read the comment docs.