kubernetes-retired / kube-aws

[EOL] A command-line tool to declaratively manage Kubernetes clusters on AWS

Apache License 2.0

1.12k stars 295 forks source link

[v0.16.x] Setup Calico Networking Option #1872

Closed dominicgunn closed 4 years ago

dominicgunn commented 4 years ago

Changes

Canal is EOL, and the only other option we offered was AWS CNI. This borrows (steals) the Calico configuration for kops, and dumps it into kube-aws so that we can use that as an option too.
This PR also fixes node labelling issues that changed between v1.15.x and v1.16.x, as we can no longer use kubelet to self label kubernetes.io tags, making nodes difficult to differentiate.
This PR also removes quay.io as the core provider for calico networking images because they keep falling over.
This PR also opens ports 4789 to allow for vxlan networking between ports, and opens communication between workers & controllers for IPnIP tunnelling used by Calico's BGP (also requiring port 179) setup.

Fsero commented 4 years ago

Hi @dominicgunn thanks for your efforts and the contribution.

I was looking into Calico docs and didn't see any official information about canal deprecation. Can you share for better context?

Thanks!

codecov-commenter commented 4 years ago

Codecov Report

Merging #1872 into v0.16.x will decrease coverage by 0.00%. The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           v0.16.x    #1872      +/-   ##
===========================================
- Coverage    24.41%   24.40%   -0.01%     
===========================================
  Files           98       98              
  Lines         5116     5117       +1     
===========================================
  Hits          1249     1249              
- Misses        3727     3728       +1     
  Partials       140      140

Impacted Files	Coverage Δ
pkg/api/assets.go	`0.00% <0.00%> (ø)`
pkg/api/region.go	`0.00% <0.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f2781f8...44383e8. Read the comment docs.

cknowles commented 4 years ago

Removed myself for review since unfortunately at the moment I don't have an appropriate stack available to check through this.

k8s-ci-robot commented 4 years ago

Keywords which can automatically close issues and at(@) mentions are not allowed in commit messages.

The list of commits with invalid commit messages:

771b148 Add gotmpl comments per @fsero

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign dominicgunn You can assign the PR to them by writing /assign @dominicgunn in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-incubator/kube-aws/blob/v0.16.x/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment