kubernetes-retired / kube-aws

[EOL] A command-line tool to declaratively manage Kubernetes clusters on AWS

Apache License 2.0

1.12k stars 295 forks source link

[v0.16.x] Migrate to new s3 URL method #1873

Closed tjamet closed 4 years ago

tjamet commented 4 years ago

Path based access has been deprecated and now returns a redirect error to bucketname.s3.amazonaws.com as explained in this post: https://aws.amazon.com/blogs/aws/amazon-s3-path-deprecation-plan-the-rest-of-the-story/

This makes cloudformation to fail as it refers to the now redirected s3 bucket path, and raises the message: S3 error: The bucket you are attempting to access must be addressed using the specified endpoint. Please send all future requests to this endpoint. For more information check http://docs.aws.amazon.com/AmazonS3/la

There is no strong documentation about what are the updates in China and Gov regions, consider it follows the same logic.

k8s-ci-robot commented 4 years ago

Welcome @tjamet!

It looks like this is your first PR to kubernetes-incubator/kube-aws 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-incubator/kube-aws has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign mumoshu You can assign the PR to them by writing /assign @mumoshu in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-incubator/kube-aws/blob/v0.16.x/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

codecov-commenter commented 4 years ago

Codecov Report

Merging #1873 into v0.16.x will decrease coverage by 0.00%. The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           v0.16.x    #1873      +/-   ##
===========================================
- Coverage    24.41%   24.40%   -0.01%     
===========================================
  Files           98       98              
  Lines         5116     5117       +1     
===========================================
  Hits          1249     1249              
- Misses        3727     3728       +1     
  Partials       140      140

Impacted Files	Coverage Δ
pkg/api/assets.go	`0.00% <0.00%> (ø)`
pkg/api/region.go	`0.00% <0.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f2781f8...f553e94. Read the comment docs.

Fsero commented 4 years ago

/assign @dominicgunn

Fsero commented 4 years ago

@tjamet could you please also patch 0.15.x and 0.14.x?

tjamet commented 4 years ago

@Fsero yes sure, did this first one for the approach to focus discussion and planned to do so when convergence on the solution

dominicgunn commented 4 years ago

Thanks for doing this @tjamet! The approach here seems good.

/lgtm

dominicgunn commented 4 years ago

Thanks for doing this @tjamet! The approach here seems good.

/lgtm