search

kubernetes-retired / kube-aws

[EOL] A command-line tool to declaratively manage Kubernetes clusters on AWS
Apache License 2.0
1.12k stars 295 forks source link

[v0.17.0] aws-iam-authenticator: upgrade to 0.5.0 #1874

Closed flah00 closed 4 years ago

flah00 commented 4 years ago

Description

These changes can be ported to the 0.15.x and 0.16.x branches, but cannot be backported any further, because of changes made to the spec.pki.keypairs[].signer feature. This PR resolves #1777 and fixes some other longstanding issues present in the plugin. With these changes, I am able to successfully make requests authenticated by aws-iam-authenticator.

Changes

Commit 1

Commit 2-4

k8s-ci-robot commented 4 years ago

Welcome @flah00!

It looks like this is your first PR to kubernetes-incubator/kube-aws 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-incubator/kube-aws has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot commented 4 years ago

Keywords which can automatically close issues and at(@) mentions are not allowed in commit messages.

The list of commits with invalid commit messages:

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign redbaron You can assign the PR to them by writing /assign @redbaron in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-incubator/kube-aws/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
dominicgunn commented 4 years ago

/lgtm

dominicgunn commented 4 years ago

Thanks for the contribution @flah00. I'll backport to 0.16.x and 0.15.x, just before I cut a release for them.