[v0.16.x] Fix node name labelling in v0.16.x clusters.

kubernetes-retired / kube-aws

[EOL] A command-line tool to declaratively manage Kubernetes clusters on AWS

Apache License 2.0

1.12k stars 295 forks source link

[v0.16.x] Fix node name labelling in v0.16.x clusters. #1894

Closed dominicgunn closed 4 years ago

dominicgunn commented 4 years ago

Changes

New restrictions on the kubelets ability to label nodes means that we can no longer label worker nodes, from the worker nodes. Instead, we need to apply a temporary label & then have the masters properly label the nodes.

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign dominicgunn You can assign the PR to them by writing /assign @dominicgunn in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-incubator/kube-aws/blob/v0.16.x/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

dominicgunn commented 4 years ago

/lgtm

k8s-ci-robot commented 4 years ago

@dominicgunn: you cannot LGTM your own PR.

In response to [this](https://github.com/kubernetes-incubator/kube-aws/pull/1894#issuecomment-688357839): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.