search

kubernetes-retired / kube-aws

[EOL] A command-line tool to declaratively manage Kubernetes clusters on AWS
Apache License 2.0
1.12k stars 295 forks source link

[v0.14.x] Adds 'disable' flag for kubedns #1899

Closed brandong954 closed 4 years ago

dominicgunn commented 4 years ago

Hey @brandong954,

Thanks for the contribution. So that we can effectively track all the changes into the project could we cut the go.mod & go.sum changes from this PR, and if we want to add them upstream open a new PR to address dependency updates?

Cheers!

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign dominicgunn You can assign the PR to them by writing /assign @dominicgunn in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-incubator/kube-aws/blob/v0.14.x/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
brandong954 commented 4 years ago

/assign @dominicgunn

dominicgunn commented 4 years ago

/lgtm

Thanks for the contribution @brandong954

brandong954 commented 4 years ago

~Ah, thanks! Not completely working yet though ...~ Actually, it does work :). When testing I was doing kube-aws render instead of just kube-aws render stack. Silly rabbit.