search

kubernetes-retired / kube-aws

[EOL] A command-line tool to declaratively manage Kubernetes clusters on AWS
Apache License 2.0
1.12k stars 295 forks source link

[v0.14.x] Always create dnsmasq-node-coredns-local.yaml #1902

Closed kfr2 closed 4 years ago

kfr2 commented 4 years ago

If this file does not exist (as would be the case if the CoreDNS local feature has not been enabled), controller nodes will fail to come up with the error:

error: the path "/srv/kubernetes/manifests/dnsmasq-node-coredns-local.yaml" does not exist

This is caused when kubectl delete is called against the file because of the line remove "${mfdir}/dnsmasq-node-coredns-local.yaml.

This manifest must always be generated because the CoreDNS-local feature cannot be enabled and then later disabled without otherwise requiring manual operator intervention.

Additionally, a previous change added a serviceaccount reference to the dnsmasq-node daemonset; this PR updates the cloud-config-controller template to create this SA alongside the daemonset.

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign davidmccormick You can assign the PR to them by writing /assign @davidmccormick in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-incubator/kube-aws/blob/v0.14.x/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment