search

kubernetes-retired / kube-aws

[EOL] A command-line tool to declaratively manage Kubernetes clusters on AWS
Apache License 2.0
1.12k stars 295 forks source link

Fix trailing whitespaces in template #1911

Closed zonzamas closed 4 years ago

zonzamas commented 4 years ago

Depending on the options combination you use, the controller template may generate the kubelet.service unit with extra white lines that break the format hence making it to fail.

I have hacked an example in playground comparing the previous combination of - for trimming whitespaces and the new one

https://play.golang.org/p/OO5T7TZA1qR

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign danielfm You can assign the PR to them by writing /assign @danielfm in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-incubator/kube-aws/blob/v0.14.x/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
Fsero commented 4 years ago

/assign @dominicgunn

dominicgunn commented 4 years ago

Thank you! Much appreciated.