search

kubernetes-retired / kube-batch

A batch scheduler of kubernetes for high performance workload, e.g. AI/ML, BigData, HPC
Apache License 2.0
1.08k stars 264 forks source link

Stop relying setting RemoveSelfLink=false feature-gate - we're locking it to true with GA graduation in 1.24 #958

Closed wojtek-t closed 2 years ago

wojtek-t commented 2 years ago

Upstream Kubernetes is going to get rid of ability to set SelfLink in release 1.24 (basically graduate graduate RemoveSelfLink feature gate to stable - see the KEP https://github.com/kubernetes/enhancements/tree/master/keps/sig-api-machinery/1164-remove-selflink, for a bit more details).

It seems that kube-batch is still vendoring Kubernetes version that is setting it to false: https://github.com/kubernetes-sigs/kube-batch/blob/master/vendor/k8s.io/apiserver/pkg/features/kube_features.go#L141

This is one more heads'up to stop relying on it (if you do in any place).

warmchang commented 2 years ago

typo: volcano --> kube-batch.

wojtek-t commented 2 years ago

Sure - fixed

ArangoGutierrez commented 2 years ago

/close

k8s-ci-robot commented 2 years ago

@ArangoGutierrez: Closing this issue.

In response to [this](https://github.com/kubernetes-sigs/kube-batch/issues/958#issuecomment-1079370048): >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.