search

kubernetes-retired / kube-batch

A batch scheduler of kubernetes for high performance workload, e.g. AI/ML, BigData, HPC
Apache License 2.0
1.08k stars 264 forks source link

Fix verify task #970

Closed aivinog1 closed 2 years ago

aivinog1 commented 2 years ago

What this PR does / why we need it:

Which issue(s) this PR fixes: Fixes #969

Special notes for your reviewer: I've just passed the whole CI and updated libraries or files that diff.

Release note:

NONE
linux-foundation-easycla[bot] commented 2 years ago

CLA Signed

The committers listed above are authorized under a signed CLA.

k8s-ci-robot commented 2 years ago

Welcome @aivinog1!

It looks like this is your first PR to kubernetes-sigs/kube-batch 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kube-batch has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot commented 2 years ago

Hi @aivinog1. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
k82cn commented 2 years ago

/ok-to-test

k82cn commented 2 years ago

Maybe we need to update go version of CI in https://github.com/kubernetes-sigs/kube-batch/blob/master/.travis.yml

I0714 11:36:16.446] hack/verify-gofmt.sh
I0714 11:36:16.626] diff -u ./vendor.go.orig ./vendor.go
I0714 11:36:16.627] --- ./vendor.go.orig    2022-07-14 11:36:16.510474425 +0000
I0714 11:36:16.627] +++ ./vendor.go 2022-07-14 11:36:16.510474425 +0000
I0714 11:36:16.627] @@ -1,3 +1,4 @@
I0714 11:36:16.627] +//go:build vendor
I0714 11:36:16.627]  // +build vendor
I0714 11:36:16.627]  
I0714 11:36:16.627]  package main
W0714 11:36:16.633] make: *** [Makefile:16: verify] Error 1
aivinog1 commented 2 years ago

Hey @k82cn. I think that the problem is a little bit deeper :) So, this build uses this image to build the code. You can see it in the manifest. And in this image, the Go version is 1.17.11.

# go version
go version go1.17.11 linux/amd64
#

So, I think we should update this Go version of the whole app:

  1. go.mod
  2. .travis.yml
  3. Maybe somewhere else too 😅
aivinog1 commented 2 years ago

And I will try to fix it here, of course :)

aivinog1 commented 2 years ago

@k82cn I've decided to not migrate with go.mod and replace the deprecated go get stuff in the hack/verify-golint.sh. I think that we should create a separate issue about full migration to 1.17.

k82cn commented 2 years ago

@k82cn I've decided to not migrate with go.mod and replace the deprecated go get stuff in the hack/verify-golint.sh. I think that we should create a separate issue about full migration to 1.17.

that's ok to me :)

aivinog1 commented 2 years ago

Hi @k82cn! As I can see right now that the build is passed. So, should I do something else to pass it through the Travis pipeline? :)

k82cn commented 2 years ago

/lgtm /approve

k8s-ci-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aivinog1, k82cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kube-batch/blob/master/OWNERS)~~ [k82cn] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment