search

kubernetes-retired / kubeadm-dind-cluster

[EOL] A Kubernetes multi-node test cluster based on kubeadm
Apache License 2.0
1.11k stars 274 forks source link

Adding support for version 1.15 #312

Closed wk8 closed 5 years ago

wk8 commented 5 years ago

Also updated other minor versions to their latest respective patches.

Added a way to make the kubelet's flags depend on its version, too: that is needed since v1.15 does not have the allow-privileged flag any more, but we still want to have it present for older versions; made that part of dind::init.

k8s-ci-robot commented 5 years ago

Welcome @wk8!

It looks like this is your first PR to kubernetes-sigs/kubeadm-dind-cluster 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubeadm-dind-cluster has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

ivan4th commented 5 years ago

/lgtm

ivan4th commented 5 years ago

/approve

k8s-ci-robot commented 5 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ivan4th, wk8

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kubeadm-dind-cluster/blob/master/OWNERS)~~ [ivan4th] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment