search

kubernetes-retired / kubefed

Kubernetes Cluster Federation
Apache License 2.0
2.5k stars 531 forks source link

fix: updating scripts to be used on quickstart #1495

Closed msdolbey closed 2 years ago

msdolbey commented 2 years ago

on macOS

What this PR does / why we need it: This should resolve this issue for macOS users for this: https://github.com/kubernetes-sigs/kubefed/issues/1494

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #1494 issue 1494

Special notes for your reviewer: I've tested this on my machine and it works for me, and I've started from scratch a few times and have encountered the same issue. So, I don't think it's isolated to me, but perhaps there is a docker version/macOS version thing that could be hanging this up. I do know this fixes the issues I encountered.

linux-foundation-easycla[bot] commented 2 years ago

CLA Signed

The committers are authorized under a signed CLA.

k8s-ci-robot commented 2 years ago

Welcome @msdolbey!

It looks like this is your first PR to kubernetes-sigs/kubefed 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubefed has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: msdolbey To complete the pull request process, please assign font after the PR has been reviewed. You can assign the PR to them by writing /assign @font in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-sigs/kubefed/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
msdolbey commented 2 years ago

Hmm - saw some tests failed - looks like some dependencies might have been bumped, and the versions that were being looked for previously may now be getting the most recent release? https://github.com/kubernetes-sigs/kubefed/runs/5313295967?check_suite_focus=true#step:4:122 If it's looking for this? https://github.com/msdolbey/kubefed/blob/msdolbey/issues-with-quickstart-macOS/Makefile#L156 but the latest release is: https://github.com/kubernetes-sigs/controller-tools/releases/tag/v0.8.0 Could that be it?

irfanurrehman commented 2 years ago

@msdolbey I will take a look at this. You will have to give me few days though... :-) In the interim, do you want to try bumping the version and see if that works?

msdolbey commented 2 years ago

Good point - I'll try to get to all these concerns this weekend. Thanks!

irfanurrehman commented 2 years ago

@msdolbey I fixed some test flakes last weekend. Can you please rebase your changes on latest. Also did you get time to address @makkes comments.

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

makkes commented 2 years ago

@msdolbey did you find the time to address the comments, yet? I'd be happy to help get this over the line

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-ci-robot commented 2 years ago

@k8s-triage-robot: Closed this PR.

In response to [this](https://github.com/kubernetes-sigs/kubefed/pull/1495#issuecomment-1220757772): >The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. > >This bot triages issues and PRs according to the following rules: >- After 90d of inactivity, `lifecycle/stale` is applied >- After 30d of inactivity since `lifecycle/stale` was applied, `lifecycle/rotten` is applied >- After 30d of inactivity since `lifecycle/rotten` was applied, the issue is closed > >You can: >- Reopen this issue or PR with `/reopen` >- Mark this issue or PR as fresh with `/remove-lifecycle rotten` >- Offer to help out with [Issue Triage][1] > >Please send feedback to sig-contributor-experience at [kubernetes/community](https://github.com/kubernetes/community). > >/close > >[1]: https://www.kubernetes.dev/docs/guide/issue-triage/ Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.