search

kubernetes-retired / kubefed

Kubernetes Cluster Federation
Apache License 2.0
2.5k stars 531 forks source link

User guide typo in script related to nginx example #1511

Closed fc92 closed 1 year ago

fc92 commented 2 years ago

What happened: In the Verify your deployment is working section of the user guide, the script Ensure nginx is running properly in each cluster is working for cluster1, not cluster2.

------------ cluster1 ------------                                                                                                      

<!DOCTYPE html>                                                                                                                         
<html>                                                                                                                                  
<head>                                                                                                                                  
<title>Welcome to nginx!</title>                                                                                                        
<style>                                                                                                                                 
html { color-scheme: light dark; }                                                                                                      
body { width: 35em; margin: 0 auto;                                                                                                     
font-family: Tahoma, Verdana, Arial, sans-serif; }                                                                                      
</style>                                                                                                                                
</head>                                                                                                                                 
<body>                                                                                                                                  
<h1>Welcome to nginx!</h1>                                                                                                              
<p>If you see this page, the nginx web server is successfully installed and                                                             
working. Further configuration is required.</p>                                                                                         

<p>For online documentation and support please refer to                                                                                 
<a href="http://nginx.org/">nginx.org</a>.<br/>                                                                                         
Commercial support is available at                                                                                                      
<a href="http://nginx.com/">nginx.com</a>.</p>                                                                                          

<p><em>Thank you for using nginx.</em></p>                                                                                              
</body>                                                                                                                                 
</html>                                                                                                                                 

------------ cluster2 ------------ 

curl: (6) Could not resolve host: 172.19.0.3cluster2-control-plane

What you expected to happen:

------------ cluster1 ------------

<!DOCTYPE html>
<html>
<head>
<title>Welcome to nginx!</title>
<style>
html { color-scheme: light dark; }
body { width: 35em; margin: 0 auto;
font-family: Tahoma, Verdana, Arial, sans-serif; }
</style>
</head>
<body>
<h1>Welcome to nginx!</h1>
<p>If you see this page, the nginx web server is successfully installed and
working. Further configuration is required.</p>

<p>For online documentation and support please refer to
<a href="http://nginx.org/">nginx.org</a>.<br/>
Commercial support is available at
<a href="http://nginx.com/">nginx.com</a>.</p>

<p><em>Thank you for using nginx.</em></p>
</body>
</html>

------------ cluster2 ------------

<!DOCTYPE html>
<html>
<head>
<title>Welcome to nginx!</title>
<style>
    body {
        width: 35em;
        margin: 0 auto;
        font-family: Tahoma, Verdana, Arial, sans-serif;
    }
</style>
</head>
<body>
<h1>Welcome to nginx!</h1>
<p>If you see this page, the nginx web server is successfully installed and
working. Further configuration is required.</p>

<p>For online documentation and support please refer to
<a href="http://nginx.org/">nginx.org</a>.<br/>
Commercial support is available at
<a href="http://nginx.com/">nginx.com</a>.</p>

<p><em>Thank you for using nginx.</em></p>
</body>
</html>

How to reproduce it (as minimally and precisely as possible): copy paste script in the documentation

Anything else we need to know?:

Environment:


- KubeFed version
master at commit a402d2e
- Scope of installation (namespaced or cluster)
cluster
- Others

<!-- DO NOT EDIT BELOW THIS LINE -->
/kind bug
k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot commented 1 year ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

k8s-ci-robot commented 1 year ago

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to [this](https://github.com/kubernetes-sigs/kubefed/issues/1511#issuecomment-1356229271): >The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. > >This bot triages issues according to the following rules: >- After 90d of inactivity, `lifecycle/stale` is applied >- After 30d of inactivity since `lifecycle/stale` was applied, `lifecycle/rotten` is applied >- After 30d of inactivity since `lifecycle/rotten` was applied, the issue is closed > >You can: >- Reopen this issue with `/reopen` >- Mark this issue as fresh with `/remove-lifecycle rotten` >- Offer to help out with [Issue Triage][1] > >Please send feedback to sig-contributor-experience at [kubernetes/community](https://github.com/kubernetes/community). > >/close not-planned > >[1]: https://www.kubernetes.dev/docs/guide/issue-triage/ Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.