Closed zer0big closed 6 years ago
I have just reviewed the latest commit. Would you make this pull request having just one unique change and divide current pull request into multi pull requests and each pull request has corresponding atomic change OR
just reflect comments with current commits & make another pull request(s) for future commits? I am just worried about such situation:
(1) @zer0big made a pull request -> @gochist reviewed -> (2) @zer0big reflects @gochist 's comments
=> such reviewing procedure is definitely fine => The reviewer(s) need to review (1) and (2) and I think it is fine.
(1) @zer0big made a pull request -> @gochist reviewed -> (2) @zer0big reflects @gochist 's comments -> (3) @zer0big accumulates more changes into the same pull request -> me reviewed
=> The reviewer(s) need to review all things: (1), (2), and (3) => That might lose what one pull request does and also committers & reviewers are on the loop of iterating commits and reviews
@ianychoi 리뷰 감사드립니다. 지적해주신 부분 수정완료 했습니다. 단, atomic에 대한 의견은 추가로 검토 부탁 드립니다~^
@zer0big 앞으로 커밋 히스토리를 정리해서 PR을 올려주시면 감사드리겠습니다. @ianychoi 님이 지적해주셨듯이 커미터, 리뷰어 모두에게 부담이 됩니다. 본 PR은 관리자에게 편집 권한을 주셨기 때문에 최종 승인단계에서 승인자가 Squash를 대신해드리는 것이 가능하므로 이대로 진행하셔도 괜찮습니다.
@gochist 먼저 의도하지 않게 부담드린 부분 지송합니다 ㅠ. 커밋 히스토리를 정리한다는 부분에 대해 좀 더 구체적인 설명 부탁드려도 될지요~? 혹시라도 여건이 되신다면, 저 같은 PR 수행 초보자들을 위한 가이드 및 Best Practice를 제시해 주셔도 좋을 듯 합니다.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: To fully approve this pull request, please assign additional approvers. We suggest the following additional approver: gochist
If they are not already assigned, you can assign the PR to them by writing /assign @gochist
in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/close
@gochist: Closing this PR.
explore 한글화작업에 대한 PR 요청 드립니다. /assign @gochist