search

kubernetes-retired / kubernetes-docs-ko

[EOL] Korean-language Kubernetes documentation
Creative Commons Attribution 4.0 International
34 stars 21 forks source link

Translate tutorials/kubernetes-basics/update in Korean #34

Closed zer0big closed 6 years ago

zer0big commented 6 years ago

ianychoi님께서 가이드 주신대로 브랜치를 새로 따서 PR 드려봅니다. 제대로 한건지 모르겠네요.. /assign gochist

k8s-ci-robot commented 6 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To fully approve this pull request, please assign additional approvers. We suggest the following additional approver: gochist

If they are not already assigned, you can assign the PR to them by writing /assign @gochist in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes/kubernetes-docs-ko/blob/dev-1.12/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
gochist commented 6 years ago

@zer0big Feature Branch(k-basic_update)에서 작업해주셨네요! :+1:

그런데 그 Feature Branch가 현재 워킹 브랜치인 kubernetes/kubernetes-docs-ko:dev-1.12에서 분기되지 않고 zer0big/kubernetes-docs-ko:dev-1.12에서 분기되어서 결과적으로 본 PR에 16개의 커밋이 들어왔고 이미 처리 된 #26 의 히스토리가 중복된 커밋으로 포함되어 있고, 처리 중인 #27 의 변경 히스토리도 포함되어있습니다.

예를 들어 origin 리모트가 다음과 같이 설정되어 있다면, 

origin  https://github.com/kubernetes/kubernetes-docs-ko (fetch)
origin  https://github.com/kubernetes/kubernetes-docs-ko (push)
zer0big https://github.com/zer0big/kubernetes-docs-ko (fetch)
zer0big https://github.com/zer0big/kubernetes-docs-ko (push)

다음과 같이 작업해주시면 update에 관련한 변경만 포함된 PR을 보내실 수 있습니다.

git fetch origin
# 원격 저장소의 dev-1.12 브랜치에서 k-basic-update-2 브랜치 체크아웃하기
git checkout origin/dev-1.12 -b k-basic-update-2
# "[20180910] k-basic-update 한글 번역본" 커밋만 가져오기
git cherry-pick 42959be 
git push zer0big k-basic-update-2
zer0big commented 6 years ago

@gochist 가이드 감사드립니다. 다시 PR 드렸습니다.

gochist commented 6 years ago

본 PR은 여기서 닫고 #35 로 처리하겠습니다. /close

k8s-ci-robot commented 6 years ago

@gochist: Closing this PR.

In response to [this](https://github.com/kubernetes/kubernetes-docs-ko/pull/34#issuecomment-420128000): >본 PR은 여기서 닫고 #35 로 처리하겠습니다. >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.