kubernetes-retired / poseidon

[EOL] A Firmament-based Kubernetes scheduler
http://www.firmament.io
Apache License 2.0
410 stars 79 forks source link

Release events feature #138

Closed shivramsrivastava closed 6 years ago

shivramsrivastava commented 6 years ago

This PR adds events support to Poseidon. When a pod is successfully scheduled or failed to be scheduled the relevant/correct event will be sent to the api-server. This events can be viewed using the command ‘kubectl get events’

k8s-ci-robot commented 6 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shivramsrivastava

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/poseidon/blob/master/OWNERS)~~ [shivramsrivastava] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
deepak-vij commented 6 years ago

/lgtm

shivramsrivastava commented 6 years ago

/test pull-poseidon-verify

k8s-ci-robot commented 6 years ago

@shivramsrivastava: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to [this](https://github.com/kubernetes-sigs/poseidon/pull/138#issuecomment-428361602): >/test pull-poseidon-verify Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
deepak-vij commented 6 years ago

/lgtm

deepak-vij commented 6 years ago

/ok-to-test

m1093782566 commented 6 years ago

cc @jiaxuanzhou

I think that's what you want :)