Closed shivramsrivastava closed 6 years ago
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: shivramsrivastava
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/assign @deepak-vij
/lgtm
/ok-to-test
/lgtm
cc @islinwb
Can you pick #112 up when this PR goes in.
@m1093782566 This PR has realized it.
This PR also includes the max-pods feature.
Oh, I missed that.
Great!
@m1093782566 @islinwb Please don't close #112 I will cherry-pick the E2E test case from that PR.
/test ci-poseidon-e2e-gce
/retest
/retest
Error logs of test:
I1011 10:45:17.862]
I1011 10:45:17.862] • Failure [16.822 seconds]
I1011 10:45:17.862] Poseidon
I1011 10:45:17.863] /go/src/github.com/kubernetes-sigs/poseidon/test/e2e/poseidon_integration.go:38
I1011 10:45:17.863] Poseidon [Predicates]
I1011 10:45:17.863] /go/src/github.com/kubernetes-sigs/poseidon/test/e2e/poseidon_integration.go:297
I1011 10:45:17.863] should validates resource limits of pods that are allowed to run [It]
I1011 10:45:17.863] /go/src/github.com/kubernetes-sigs/poseidon/test/e2e/poseidon_integration.go:314
I1011 10:45:17.863]
I1011 10:45:17.863] Expected error:
I1011 10:45:17.863] <*errors.errorString | 0xc000335ba0>: {
I1011 10:45:17.863] s: "pod ran to completion",
I1011 10:45:17.863] }
I1011 10:45:17.863] pod ran to completion
I1011 10:45:17.863] not to have occurred
I1011 10:45:17.863]
I1011 10:45:17.864] /go/src/github.com/kubernetes-sigs/poseidon/test/e2e/poseidon_integration.go:422
I1011 10:45:17.864] ------------------------------
/retest
New changes are detected. LGTM label has been removed.
Will be closing the PR for now. Some issues with resource calculation and max-pods feature, will investigate and create a new PR soon.
@shivramsrivastava: The following test failed, say /retest
to rerun them all:
Test name | Commit | Details | Rerun command |
---|---|---|---|
ci-poseidon-e2e-gce | f2cdccf7409f2314a3f69378470641389cc6c1c3 | link | /test ci-poseidon-e2e-gce |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
This PR add a new informer to view other pods not scheduled by Poseidon. This information is required for resource calculation of node and also for max-pods feature. This PR also includes the max-pods feature.