search

kubernetes-retired / poseidon

[EOL] A Firmament-based Kubernetes scheduler
http://www.firmament.io
Apache License 2.0
410 stars 79 forks source link

Add design docs on taints and tolerations, gang scheduling #141

Closed islinwb closed 6 years ago

islinwb commented 6 years ago

/assign @m1093782566

m1093782566 commented 6 years ago

cc @jiaxuanzhou

jiaxuanzhou commented 6 years ago

looks good, but one suggestion: the proposal does not mention the priority of the jobs, here is one scenario: job1 (high priority), job2(low priority) pods of job0 are running, pods of job1/job2 are pending as there is not enough resource, when job0 completed, resource is released and can only satisfy the request of job1 or job2, but only pods of job1 can be placed as it has high priority.

would you also consider this feature in your design?

m1093782566 commented 6 years ago

cc @deepak-vij @shivramsrivastava for inputs.

m1093782566 commented 6 years ago

/test ci-poseidon-e2e-gce

m1093782566 commented 6 years ago

I think we can let these two design proposals in for now. After that, we can refine the gang scheduling design document per the codes.

m1093782566 commented 6 years ago

/lgtm

/approve

k8s-ci-robot commented 6 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: islinwb, m1093782566

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/poseidon/blob/master/OWNERS)~~ [m1093782566] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment